Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MEGAN compatibility with FATES #99

Merged

Conversation

mvertens
Copy link

@mvertens mvertens commented Nov 20, 2024

Description of changes

  • Megan changes without the fire emissions commits.
  • updated testlist for aux_noresm_clm
  • removal of ctsm5.1
  • updates of submodules to be consistent with upcoming noresm2_5_alpha08 tag

Specific notes

Same notes as the previous now closed PR
#74

Contributors other than yourself, if any: @rosiealice (the primary developer of these changes)

CTSM Issues Fixed (include github issue #):
#36

Are answers expected to change (and if so in what way)?
Yes, all the MEG_* fields will change, but nothing else.

Any User Interface Changes (namelist or namelist defaults changes)?
No

Does this create a need to change or add documentation? Did you do so?
Yes, but haven;'t changed yet pending further coupled model testing.

Testing performed, if any:
Ran the following test command:
./create_test --xml-category aux_clm_noresm --xml-machine betzy --baseline-root ~/baselines/ctsm_develop --generate noresm2_5_alpha08 --test-id ctsmpr1 --project nn9039k -o

    FAIL ERS_Ld761.ne30pg3_ne30pg3_mtn14.2000_DATM%GSWP3v1_CLM60%FATES-NOCOMP_SICE_SOCN_MOSART_SGLC_SWAV.betzy_intel.clm-FatesColdNoComp RUN time=2995
    FAIL SMS_D.1x1_brazil.2000_DATM%GSWP3v1_CLM60%FATES-SP_SICE_SOCN_SROF_SGLC_SWAV.betzy_intel.clm-FatesColdDryDepSatPhen RUN time=56
    FAIL SMS_D_Ld3.ne30pg3_ne30pg3_mtn14.2000_DATM%GSWP3v1_CLM60%FATES-SP_SICE_SOCN_SROF_SGLC_SWAV.betzy_intel.clm-FatesColdSatPhen_prescribed RUN time=62

All the other tests passed.

rosiealice and others added 30 commits November 11, 2024 15:30
@mvertens mvertens mentioned this pull request Nov 20, 2024
@mvertens mvertens changed the title Feature/megan cherrypick ctsm mvertens add MEGAN compatibility with FATES Nov 20, 2024
@mvertens mvertens self-assigned this Nov 20, 2024
@mvertens mvertens added the enhancement New feature or request label Nov 20, 2024
@mvertens mvertens added this to the NorESM2.5 milestone Nov 20, 2024
@mvdebolskiy
Copy link
Collaborator

Ok. I've pushed some changes to make things clearer.

@mvertens
Copy link
Author

Did you test to see if the answers were bfb - both with non-fates and fates?

@mvdebolskiy
Copy link
Collaborator

No, not yet. I wanted to look at the fates side tomorrow. Can you try to tests this?

@mvertens
Copy link
Author

I'm concerned about your changes. This code was vetted closely and worked. You are putting in an optimization that would be fine for a second stage - but this is holding up simulations and could come in as a secondary phase. The key priority right now is to have the next simulation done.

@mvdebolskiy mvdebolskiy force-pushed the feature/megan_cherrypick_ctsm_mvertens branch from 4b2f14f to c89f3cc Compare November 21, 2024 20:50
Copy link
Collaborator

@rosiealice rosiealice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved in CTSM meeting.

@rosiealice rosiealice merged commit ca5cddb into NorESMhub:noresm Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

Update CTSM to latest ESCOMP/master and update externals. Running new noresm testlist on betzy
3 participants