-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MEGAN compatibility with FATES #99
add MEGAN compatibility with FATES #99
Conversation
…TES PFTs and HLM PFTs
…an_cherrypick_ctsm_mvertens
Fix handling of finidat with cold starts
…he system if you update to ceps1.0.58
…errypick_ctsm_mvertens
Ok. I've pushed some changes to make things clearer. |
Did you test to see if the answers were bfb - both with non-fates and fates? |
No, not yet. I wanted to look at the fates side tomorrow. Can you try to tests this? |
I'm concerned about your changes. This code was vetted closely and worked. You are putting in an optimization that would be fine for a second stage - but this is holding up simulations and could come in as a secondary phase. The key priority right now is to have the next simulation done. |
4b2f14f
to
c89f3cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes approved in CTSM meeting.
Description of changes
Specific notes
Same notes as the previous now closed PR
#74
Contributors other than yourself, if any: @rosiealice (the primary developer of these changes)
CTSM Issues Fixed (include github issue #):
#36
Are answers expected to change (and if so in what way)?
Yes, all the MEG_* fields will change, but nothing else.
Any User Interface Changes (namelist or namelist defaults changes)?
No
Does this create a need to change or add documentation? Did you do so?
Yes, but haven;'t changed yet pending further coupled model testing.
Testing performed, if any:
Ran the following test command:
./create_test --xml-category aux_clm_noresm --xml-machine betzy --baseline-root ~/baselines/ctsm_develop --generate noresm2_5_alpha08 --test-id ctsmpr1 --project nn9039k -o
All the other tests passed.